Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PA-5938] Add support for debian & amazon linux in beaker 4.x #1828

Merged
merged 5 commits into from
Nov 15, 2023
Merged

[PA-5938] Add support for debian & amazon linux in beaker 4.x #1828

merged 5 commits into from
Nov 15, 2023

Conversation

span786
Copy link
Contributor

@span786 span786 commented Nov 7, 2023 •
edited
Loading

Support for following platforms is added to 4.x as we need them to work for our Amazon lInux 2023 platform release for FOSS.

  • Amazon Linux
  • Debian

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9c0721f) 74.91% compared to head (17d2e09) 74.94%.

❗ Current head 17d2e09 differs from pull request most recent head 03a76bc. Consider uploading reports for the commit 03a76bc to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##              4.x    #1828      +/-   ##
==========================================
+ Coverage   74.91%   74.94%   +0.03%     
==========================================
  Files          82       82              
  Lines        4863     4865       +2     
==========================================
+ Hits         3643     3646       +3     
+ Misses       1220     1219       -1
Files Coverage Δ
lib/beaker/host/unix/exec.rb 73.30% <100.00%> (ø)
lib/beaker/host/unix/file.rb 90.90% <ø> (ø)
lib/beaker/host_prebuilt_steps.rb 74.83% <100.00%> (+0.50%) ⬆️
lib/beaker/platform.rb 100.00% <100.00%> (ø)
lib/beaker/perf.rb 56.45% <66.66%> (ø)
lib/beaker/host/unix/pkg.rb 67.02% <36.36%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@span786 span786 marked this pull request as draft November 7, 2023 13:45
ekohl
ekohl reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a bit easier to review if you separated out the style changes from the actual Amazon addition into a separate commit.

@span786
Copy link
Contributor Author

span786 commented Nov 9, 2023

Hi @ekohl,

Thank you so much for you review comment.

These changes are cherry-picked from 5.x branch into 4.x. I could not have been able to separate out the style changes from actual amazon changes. I think the style changes are there because 4.x branch is not using %w[] to create array of strings.

@span786 span786 marked this pull request as ready for review November 9, 2023 05:54
@span786 span786 requested a review from ekohl November 9, 2023 05:54
@shubhamshinde360 shubhamshinde360 mentioned this pull request Nov 9, 2023
Closed
@mhashizume mhashizume merged commit b810cbe into voxpupuli:4.x Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@ekohl ekohl Awaiting requested review from ekohl

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@span786 @ekohl @bastelfreak @mhashizume @yachub